[Master] - Bug 641309: Sustainability - Use specific carbon tracking for item reclassification#9517
Closed
v-rohangarg20 wants to merge 3 commits into
Closed
Conversation
Contributor
|
1 similar comment
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workitem Bug 641309: [master] [Sustainability][Value Chain] Item Reclassification (location move) uses average emissions instead of Specific carbon tracking (lot/serial)
Fixes AB#641309
Issue: When an item uses Carbon Tracking Method = Specific, an Item Reclassification that moves the item to another location transferred the cost correctly (per the tracked lots/serials) but the emissions were calculated from an averaged CO2e per Unit × Quantity, ignoring the specific per-lot/serial CO2e.
Cause: In GetTotalCO2eAmount (SustainabilityPostMgt), Transfer entries short-circuited and set TotalCO2e := Abs(CO2ePerUnit * Quantity) using the averaged CO2e per unit, exiting before consulting the applied source entries that hold the specific lot/serial CO2e.
Solution: In GetTotalCO2eAmount, run the applied-entries lookup first and, for Transfer entries, derive TotalCO2e from the specific applied CO2e (AppliedAmount / AppliedQuantity × Quantity), falling back to the averaged CO2e per unit only when no specific applied data exists. Emissions now follow the moved lots/serials, mirroring how cost is transferred.